hachikuji commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663403189
##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -340,7 +338,8 @@ class BrokerServer(
SocketServer.DataPlaneThreadPrefix)
if (socketServer.controlPlaneRequestChannelOpt.isDefined) {
- throw new RuntimeException("KIP-291 endpoints are not supported when
in KRaft mode.")
+ throw new RuntimeException("KIP-291 control plane listeners are not
supported " +
Review comment:
nit: you might have missed my comment. Can we mention the configuration
`control.plane.listener.name` explicitly instead of KIP-291?
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -2011,7 +2011,16 @@ class ReplicaManager(val config: KafkaConfig,
"directory.")
None
- case HostedPartition.Online(partition) => Some(partition, false)
+ case HostedPartition.Online(partition) => {
+ if (partition.topicId.isDefined && !partition.topicId.equals(topicId))
{
Review comment:
The second check here is not right since `topicId` is not an option. I
think what we want is this?
```scala
if (partition.topicId.exists(_ != topicId)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
