hachikuji commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r667164215
##########
File path: docs/upgrade.html
##########
@@ -21,6 +21,7 @@
<h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in
3.0.0</a></h5>
<ul>
+ <li>A Principal Serde defenition is now required. A default has been set
for KafkaPrincipalBuilder which implements KafkaPrincipalSerde</li>
Review comment:
We can probably be more verbose. Maybe something like this:
> Custom principal builder implementations specified through
<code>principal.builder.class</code> must now implement the
<code>KafkaPrincipalSerde</code> interface to allow for forwarding between
brokers. Additionally, the default value for this configuration has been
changed
to<code>org.apache.kafka.common.security.authenticator.DefaultKafkaPrincipalBuilder</code>,
which was already the implicit behavior when no principal builder was defined.
See <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-590%3A+Redirect+Zookeeper+Mutation+Protocols+to+The+Controller";>KIP-590</a>
for more details about the usage of <code>KafkaPrincipalSerde</code>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
