hachikuji commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r667225066
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1975,6 +1975,8 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
s" ${KafkaConfig.ConnectionsMaxIdleMsProp}=$connectionsMaxIdleMs to
prevent failed" +
s" authentication responses from timing out")
-
require(classOf[KafkaPrincipalSerde].isAssignableFrom(getClass(KafkaConfig.PrincipalBuilderClassProp)),
"A principal serde must be defined")
+ require(KafkaConfig.PrincipalBuilderClassProp != null,
"principal.builder.class must be non-null")
Review comment:
We need to check `getClass(KafkaConfig.PrincipalBuilderClassProp))`,
right? Maybe we can create a `val`.
```scala
val principalBuilderClass = getClass(KafkaConfig.PrincipalBuilderClassProp)
require(principalBuilderClass != null, "principal.builder.class must be
defined")
require(classOf[KafkaPrincipalSerde].isAssignableFrom(principalBuilderClass),
"principal.builder.class must implement KafkaPrincipalSerde")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
