showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667309320
##########
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##########
@@ -290,14 +340,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
Logging {
assertEquals("[[1, 2], [3, 4]]", addedProps.getProperty("nested"))
}
- def doTestOptionEntityTypeNames(zkConfig: Boolean): Unit = {
- val connectOpts = if (zkConfig)
- ("--zookeeper", zkConnect)
- else
- ("--bootstrap-server", "localhost:9092")
-
+ def doTestOptionEntityTypeNames(): Unit = {
Review comment:
Thanks for reminder! I added the removed test back, and only test "user"
and "brokers" config type for `zkConfig`. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
