[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

[GitBox]

showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667309248



##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -876,6 +872,11 @@ object ConfigCommand extends Config {
         throw new IllegalArgumentException(s"--bootstrap-server must be 
specified for --all")
       }
 
+      if (options.has(zkTlsConfigFile) && options.has(bootstrapServerOpt)) {
+        throw new IllegalArgumentException("--bootstrap-server doesn't support 
--zk-tls-config-file option. " +
+          "Please use --zookeeper option instead")

Review comment:
       Good suggestion! Updated the message to:
   `--bootstrap-server doesn't support --zk-tls-config-file option. If you are 
trying to update the ZooKeeper TLS configuration, please use --zookeeper option 
instead. Otherwise, Please remove --zk-tls-config-file option.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org