cadonna commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-878965687


   > However, looking into the code I am a little bit confused about 
maintainMs() in TimeWindows:
   > 
   ```
   public long maintainMs() {
       return Math.max(maintainDurationMs, sizeMs + gracePeriodMs());
   }
   ```
   
   This code is indeed a bit complicated. I did some investigation and came to 
the following results:
   
   For 2.8 the retention times with default grace period are:
   - `TimeWindows`: 
     - **24h** if window size is less than 24h, 
     - **window size** if window size is greater than or equal to 24h.
   - `SessionWindows`:
     - **24h** if the inactivity gap is less than 24h,
     - **inactivity gap** if the inactivity gap is greater than or equal to 24h.
   - `JoinWindows`:
     - **24h** if window size is less than 24h,
     - **window size** if window size is greater than or equal to 24h.
   
   For 3.0 the retention times with default grace period are:
   - `TimeWindows`: 
     - **window size + grace windows**
   - `SessionWindows`:
     - **inactivity gap + grace windows**
   - `JoinWindows`:
     - **window size + grace windows**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to