ableegoldman commented on a change in pull request #10683:
URL: https://github.com/apache/kafka/pull/10683#discussion_r669192999



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -345,8 +343,17 @@ private SinkNodeFactory(final String name,
         }
     }
 
+    public void setTopologyName(final String namedTopology) {
+        Objects.requireNonNull(namedTopology, "named topology can't be null");
+        if (this.namedTopology != null) {
+            log.error("Tried to reset the namedTopology to {} but it was 
already set to {}", namedTopology, this.namedTopology);
+            throw new IllegalStateException("NamedTopology has already been 
set to " + this.namedTopology);
+        }
+        this.namedTopology = namedTopology;
+    }
+
     // public for testing only
-    public synchronized final InternalTopologyBuilder setApplicationId(final 
String applicationId) {

Review comment:
       I looked around and can't imagine why we would ever need it. 
`setApplicationId` should only ever be called once, from a single 
location/thread




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to