ableegoldman commented on a change in pull request #10683:
URL: https://github.com/apache/kafka/pull/10683#discussion_r669233192
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -345,8 +343,17 @@ private SinkNodeFactory(final String name,
}
}
+ public void setTopologyName(final String namedTopology) {
Review comment:
I tried to, but just couldn't make it work. It has to do with Java and
subclassing quirks like constructing the parent before the child. It seems to
be pretty much impossible to set things up so that everything is `final` -- if
we set the `topologyName` in the NamedTopology constructor, then it's not
accessible (ie always null) when we call the `InternalTopologyBuilder`'s
constructor since that occurs during the parent `Topology`'s construction.
It's definitely annoying, but at least we should be able to clean things up
once we go through a KIP and don't need to subclass like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
