cmccabe commented on a change in pull request #11084:
URL: https://github.com/apache/kafka/pull/11084#discussion_r672715848
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -755,11 +766,22 @@ public void handleLeaderChange(LeaderAndEpoch newLeader) {
newEpoch + ", but we never renounced controller
epoch " +
curEpoch);
}
- log.warn("Becoming active at controller epoch {}.",
newEpoch);
+ log.info(
Review comment:
This can fit in two lines... let's try to avoid "exploded" function
calls that look like function bodies.
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -755,11 +766,22 @@ public void handleLeaderChange(LeaderAndEpoch newLeader) {
newEpoch + ", but we never renounced controller
epoch " +
curEpoch);
}
- log.warn("Becoming active at controller epoch {}.",
newEpoch);
+ log.info(
Review comment:
This can fit in two or three lines... let's try to avoid "exploded"
function calls that look like function bodies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
