cmccabe commented on a change in pull request #11084:
URL: https://github.com/apache/kafka/pull/11084#discussion_r672716671
##########
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java
##########
@@ -178,14 +178,18 @@ public Snapshot getSnapshot(long epoch) {
/**
* Creates a new snapshot at the given epoch.
*
+ * If {@code epoch} already exists and it is the last snapshot then just
return that snapshot.
Review comment:
With this modification, the function should be renamed something like
`getOrCreateSnapshot`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
