[GitHub] [kafka] hachikuji commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

[GitBox]

hachikuji commented on a change in pull request #11126:
URL: https://github.com/apache/kafka/pull/11126#discussion_r678678022



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1394,15 +1394,11 @@ class ReplicaManager(val config: KafkaConfig,
                 responseMap.put(topicPartition, Errors.STALE_CONTROLLER_EPOCH)
               } else {
                 // The controller may send LeaderAndIsr to upgrade to using 
topic IDs without bumping the epoch.
+                // If we have a matching epoch, we expect the log to be 
defined.
+                val log = localLogOrException(partition.topicPartition)

Review comment:
       nit: since we don't need this in the `_` case, can we move it down?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org