jolshan commented on a change in pull request #11126:
URL: https://github.com/apache/kafka/pull/11126#discussion_r679404417



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1392,11 +1393,24 @@ class ReplicaManager(val config: KafkaConfig,
                   s"leader epoch $currentLeaderEpoch")
                 responseMap.put(topicPartition, Errors.STALE_CONTROLLER_EPOCH)
               } else {
-                stateChangeLogger.info(s"Ignoring LeaderAndIsr request from " +
-                  s"controller $controllerId with correlation id 
$correlationId " +
-                  s"epoch $controllerEpoch for partition $topicPartition since 
its associated " +
-                  s"leader epoch $requestLeaderEpoch matches the current 
leader epoch")
-                responseMap.put(topicPartition, Errors.STALE_CONTROLLER_EPOCH)
+                // The controller may send LeaderAndIsr to upgrade to using 
topic IDs without bumping the epoch.

Review comment:
       I originally put it there to explain why we had the case in the first 
place, but it still gets the point across in the first case. I'll move it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to