showuon commented on a change in pull request #11120:
URL: https://github.com/apache/kafka/pull/11120#discussion_r678771300
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java
##########
@@ -65,9 +66,10 @@
* Order is not guaranteed as bytes lexicographical ordering might not
represent key order.
*
* @param from The first key that could be in the range, where iteration
ends.
+ * A null value indicates that the range ends with the first
element in the store.
* @param to The last key that could be in the range, where iteration
starts from.
+ * A null value indicates a starting position from the last
element in the store.
Review comment:
@vvcephei is correct. The `from` is still the lower bound and and `to`
is the upper bound in the `reverseRange` method definition. We can confirm it
by checking the parameter validation in the `CachingKeyValueStore#reverseRange`
```
public KeyValueIterator<Bytes, byte[]> reverseRange(final Bytes from,
final Bytes to) {
if (from.compareTo(to) > 0) {
LOG.warn("Returning empty iterator for fetch with invalid key
range: from > to. " +
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
