patrickstuedi commented on a change in pull request #11120:
URL: https://github.com/apache/kafka/pull/11120#discussion_r679163645



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java
##########
@@ -81,6 +82,16 @@ public void after() {
         return result;
     }
 
+    private static List<KeyValue<Integer, String>> getOrderedContents(final 
KeyValueIterator<Integer, String> iter) {
+        final LinkedList<KeyValue<Integer, String>> result = new 
LinkedList<>();
+        while (iter.hasNext()) {
+            final KeyValue<Integer, String> entry = iter.next();
+            result.add(entry);
+        }
+
+        return result;
+    }

Review comment:
       Makes sense. I changed to the code to use existing util functions 
whenever possible. If you think the changes overshoot let me know, I'm also not 
entirely sure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to