hachikuji commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r694219292
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -594,13 +594,21 @@ class KafkaServer(
val clientResponse =
NetworkClientUtils.sendAndReceive(networkClient, request, time)
val shutdownResponse =
clientResponse.responseBody.asInstanceOf[ControlledShutdownResponse]
- if (shutdownResponse.error == Errors.NONE &&
shutdownResponse.data.remainingPartitions.isEmpty) {
+ if (shutdownResponse.error != Errors.NONE) {
+ info(s"Controlled shutdown request returned after
${clientResponse.requestLatencyMs}ms " +
+ s"with error ${shutdownResponse.error}")
Review comment:
Hmm, I think INFO is ok. Retries in some cases are not uncommon. It's
only an error if we unclean shutdown after all retries have failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
