hachikuji commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r694226505
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -611,7 +619,7 @@ class KafkaServer(
// ignore and try again
}
}
- if (!shutdownSucceeded) {
+ if (!shutdownSucceeded && remainingRetries > 0) {
Thread.sleep(config.controlledShutdownRetryBackoffMs)
warn("Retrying controlled shutdown after the previous attempt
failed...")
Review comment:
I decided to leave this as a separate message since there are 3 cases
where we might need to retry. However, I changed the level to INFO to be
consistent and I added `remainingRetries` to the message as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
