satishd commented on a change in pull request #11033:
URL: https://github.com/apache/kafka/pull/11033#discussion_r704953596
##########
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java
##########
@@ -62,16 +63,17 @@
* @param remoteLogSegmentMetadata metadata about the remote log segment.
* @throws RemoteStorageException if there are any storage related
errors occurred.
* @throws IllegalArgumentException if the given metadata instance does
not have the state as {@link RemoteLogSegmentState#COPY_SEGMENT_STARTED}
+ * @return a CompletableFuture which will complete once this operation is
finished.
*/
- void addRemoteLogSegmentMetadata(RemoteLogSegmentMetadata
remoteLogSegmentMetadata) throws RemoteStorageException;
+ CompletableFuture<Void>
addRemoteLogSegmentMetadata(RemoteLogSegmentMetadata remoteLogSegmentMetadata)
throws RemoteStorageException;
/**
- * This method is used to update the {@link RemoteLogSegmentMetadata}.
Currently, it allows to update with the new
+ * This method is used to update the {@link RemoteLogSegmentMetadata}
asynchronously. Currently, it allows to update with the new
* state based on the life cycle of the segment. It can go through the
below state transitions.
* <p>
* <pre>
* +---------------------+ +----------------------+
- * |COPY_SEGMENT_STARTED |----------->|COPY_SEGMENT_FINISHED |
+ * |COPY_SEGMENT_STARTED |----------->|COPY_SEGMENT_FINISHED |
Review comment:
I verified that the correct HTML is generated in the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
