dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r710075575
##########
File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala
##########
@@ -163,6 +163,17 @@ abstract class AbstractFetcherManager[T <:
AbstractFetcherThread](val name: Stri
info(s"Added fetcher to broker ${fetcherThread.sourceBroker.id} for
partitions $initialOffsetAndEpochs")
}
+ def addTopicIdsToFetcherThread(partitionsToUpdate: Set[(TopicPartition,
BrokerAndFetcherId)], topicIds: String => Option[Uuid]): Unit = {
+ lock synchronized {
+ val partitionsPerFetcher = partitionsToUpdate.groupMap(_._2)(_._1)
+
+ for ((brokerAndFetcherId, partitions) <- partitionsPerFetcher) {
+ val brokerIdAndFetcherId =
BrokerIdAndFetcherId(brokerAndFetcherId.broker.id, brokerAndFetcherId.fetcherId)
Review comment:
Yeah, that's right. I think that an important point is to let the
FetcherManager compute the fetcher id based on the topic-partition instead of
computing it in the replica manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
