jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r711204996
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1755,6 +1762,40 @@ class ReplicaManager(val config: KafkaConfig,
partitionsToMakeFollower
}
+ private def updateTopicIdForFollowers(controllerId: Int,
+ controllerEpoch: Int,
+ partitionStates: Set[Partition],
+ correlationId: Int,
+ topicIds: String => Option[Uuid]):
Unit = {
+ val traceLoggingEnabled = stateChangeLogger.isTraceEnabled
+
+ try {
+ if (isShuttingDown.get()) {
+ if (traceLoggingEnabled) {
+ partitionStates.foreach { partition =>
+ stateChangeLogger.trace(s"Skipped the update topic ID step of the
become-follower state " +
+ s"change with correlation id $correlationId from controller
$controllerId epoch $controllerEpoch for " +
+ s"partition ${partition.topicPartition} since it is shutting
down")
+ }
+ }
+ } else {
+ val partitionsToUpdateFollowerWithLeader = partitionStates.map {
partition =>
+ val leaderNode = partition.leaderReplicaIdOpt.flatMap(leaderId =>
metadataCache.
+ getAliveBrokerNode(leaderId,
config.interBrokerListenerName)).getOrElse(Node.noNode())
+ val leaderId = leaderNode.id
Review comment:
Ah I see. I thought I copied the check from makeFollowers, but I guess I
didn't. And I thought I removed the extra work to get the ID, but looks like
there was still an unnecessary step. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
