showuon commented on a change in pull request #11404:
URL: https://github.com/apache/kafka/pull/11404#discussion_r730742444
##########
File path: docs/streams/developer-guide/config-streams.html
##########
@@ -1025,12 +1034,19 @@ <h4><a class="toc-backref" href="#id22">acks</a><a
class="headerlink" href="#ack
<h4><a class="toc-backref" href="#id23">replication.factor</a><a
class="headerlink" href="#id2" title="Permalink to this headline"></a></h4>
<blockquote>
<div>See the <a class="reference internal"
href="#replication-factor-parm"><span class="std std-ref">description
here</span></a>.</div></blockquote>
- <pre class="line-numbers"><code class="language-java">Properties
streamsSettings = new Properties();
-streamsSettings.put(StreamsConfig.REPLICATION_FACTOR_CONFIG, 3);
+ </div>
+ <div class="section" id="i32">
+ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a
class="headerlink" href="#id2" title="Permalink to this headline"></a></h4>
+ <blockquote>
+ <div>See the <a class="reference internal"
href="#streams-developer-guide-standby-replicas"><span class="std
std-ref">description here</span></a>.</div></blockquote>
+ </div>
+ <pre class="line-numbers"><code class="language-java">Properties
streamsSettings = new Properties();
+// for broker version is 2.3. or older
Review comment:
additional dot is added.
// for broker version is 2.3[.] or older
##########
File path: docs/streams/developer-guide/config-streams.html
##########
@@ -680,14 +680,18 @@ <h4><a class="toc-backref"
href="#id33">default.windowed.value.serde.inner</a><a
preferred to restart on an instance that has standby replicas so
that the local state store restoration process from its
changelog can be minimized. Details about how Kafka Streams
makes use of the standby replicas to minimize the cost of
resuming tasks on failover can be found in the <a
class="reference internal"
href="../architecture.html#streams_architecture_state"><span class="std
std-ref">State</span></a> section.
+ <dl class="docutils">
+ <dt>Recommendation:</dt>
+ <dd>Increase the number of standbys to 1 to get instant
fail-over, ie, high-availability.
Review comment:
ie, high-availability. -> i.e., high-availability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
