rajinisivaram commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745938340
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
private val reconfigurables = mutable.Buffer[Reconfigurable]()
private val brokerReconfigurables = mutable.Buffer[BrokerReconfigurable]()
private val lock = new ReentrantReadWriteLock
- private var currentConfig = kafkaConfig
+ private var currentConfig: KafkaConfig = null
private val dynamicConfigPasswordEncoder =
maybeCreatePasswordEncoder(kafkaConfig.passwordEncoderSecret)
- private[server] def initialize(zkClient: KafkaZkClient): Unit = {
+ private[server] def initialize(zkClientOpt: Option[KafkaZkClient]): Unit = {
Review comment:
In the ZK world, all ZK configs are static configs. We initialize
dynamic configs very early on, once we have a ZK client that we create with ZK
configs.
For the non-ZK world, I wasn't sure if the initialization required some
dynamic configs. For example, we allow SSL keystore passwords to be stored in
ZK prior to starting up brokers to avoid specifying any passwords in
server.properties. Do we ensure that SocketServer only starts up after dynamic
configs are initialized with KRaft?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
