showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141328
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##########
@@ -660,15 +645,12 @@ public void
verifyDeprecatedPollDoesNotTimeOutDuringMetadataUpdate() {
@Test
public void verifyNoCoordinatorLookupForManualAssignmentWithSeek() {
- Time time = new MockTime();
- SubscriptionState subscription = new SubscriptionState(new
LogContext(), OffsetResetStrategy.EARLIEST);
ConsumerMetadata metadata = createMetadata(subscription);
MockClient client = new MockClient(time, metadata);
initMetadata(client, Collections.singletonMap(topic, 1));
- ConsumerPartitionAssignor assignor = new RoundRobinAssignor();
- KafkaConsumer<String, String> consumer = newConsumer(time, client,
subscription, metadata, assignor, true, groupInstanceId);
+ KafkaConsumer<String, String> consumer = newConsumer(time, client,
subscription, metadata, assignor, true, null, groupInstanceId, false);
Review comment:
This test case is to test manual assignment without storing offsets. So
we should not create `groupID` (the third parameter from the end)
test added for this issue: https://issues.apache.org/jira/browse/KAFKA-4034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
