showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141904
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -488,7 +492,7 @@ public boolean poll(Timer timer, boolean waitForJoinGroup) {
// Always update the heartbeat last poll time so that the
heartbeat thread does not leave the
// group proactively due to application inactivity even if (say)
the coordinator cannot be found.
pollHeartbeat(timer.currentTimeMs());
- if (coordinatorUnknown() && !ensureCoordinatorReady(timer)) {
+ if (coordinatorUnknownAndUnready(timer)) {
Review comment:
> Could we move the whole block before the if-else block and also update
the related comments?
We can't because we should always lookup the coordinator after heartbeat
poll to avoid the heartbeat timeout in group management case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
