[GitHub] [kafka] dajac commented on a change in pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

[GitBox]

dajac commented on a change in pull request #11688:
URL: https://github.com/apache/kafka/pull/11688#discussion_r803835704



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -699,11 +702,15 @@ public void handle(JoinGroupResponse joinResponse, 
RequestFuture<ByteBuffer> fut
         return sendSyncGroupRequest(requestBuilder);
     }
 
-    private RequestFuture<ByteBuffer> onJoinLeader(JoinGroupResponse 
joinResponse) {
+    private RequestFuture<ByteBuffer> onLeaderElected(JoinGroupResponse 
joinResponse) {
         try {
             // perform the leader synchronization and send back the assignment 
for the group
-            Map<String, ByteBuffer> groupAssignment = 
performAssignment(joinResponse.data().leader(), 
joinResponse.data().protocolName(),
-                    joinResponse.data().members());
+            Map<String, ByteBuffer> groupAssignment = onLeaderElected(
+                joinResponse.data().leader(),
+                joinResponse.data().protocolName(),
+                joinResponse.data().members(),
+                joinResponse.data().skipAssignment()
+            );

Review comment:
       Given that we already have unit tests verifying this for the two 
implementations, the extra validation seems unnecessary to me. I can do it 
though if you believe that there is value in it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org