dajac commented on a change in pull request #11688:
URL: https://github.com/apache/kafka/pull/11688#discussion_r804630897
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
##########
@@ -211,7 +211,13 @@ protected void onJoinComplete(int generation, String
memberId, String protocol,
}
@Override
- protected Map<String, ByteBuffer> performAssignment(String leaderId,
String protocol, List<JoinGroupResponseMember> allMemberMetadata) {
+ protected Map<String, ByteBuffer> onLeaderElected(String leaderId,
+ String protocol,
+
List<JoinGroupResponseMember> allMemberMetadata,
+ boolean skipAssignment) {
+ if (skipAssignment)
+ throw new IllegalStateException("Can't skip assignment because
Connect does not support static membership.");
Review comment:
The fundamental issue is that the assignor is not idempotent nor free of
any side effects (e.g. custom ones) so running it and ignoring the new
assignment would lead to a weird state for the group. This is briefly discussed
in the KIP, see rejected alternatives. I have updated the comment in the
GroupCoordinator to stress out this point. Does this work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
