jolshan commented on a change in pull request #11784:
URL: https://github.com/apache/kafka/pull/11784#discussion_r812184917
##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -209,6 +211,11 @@ class BrokerServer(
val controllerNodes =
RaftConfig.voterConnectionsToNodes(controllerQuorumVotersFuture.get()).asScala
val controllerNodeProvider = RaftControllerNodeProvider(raftManager,
config, controllerNodes)
+ val currentNodeControllerApiVersions = if (config.isKRaftCoResidentMode)
{
+ Some(new
NodeApiVersions(ApiKeys.controllerApis().asScala.map(ApiVersionsResponse.toApiVersion).asJava))
+ } else {
+ None
Review comment:
Unless I'm misreading the code, it seems like this was not None before.
Are there implications for adding the None case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
