dengziming commented on a change in pull request #11784:
URL: https://github.com/apache/kafka/pull/11784#discussion_r812644858
##########
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##########
@@ -68,28 +67,14 @@ object AlterIsrManager {
* Factory to AlterIsr based implementation, used when IBP >= 2.7-IV2
*/
def apply(
- config: KafkaConfig,
- metadataCache: MetadataCache,
+ alterIsrChannelManager: BrokerToControllerChannelManager,
scheduler: KafkaScheduler,
time: Time,
- metrics: Metrics,
- threadNamePrefix: Option[String],
brokerEpochSupplier: () => Long,
brokerId: Int
): AlterIsrManager = {
- val nodeProvider = MetadataCacheControllerNodeProvider(config,
metadataCache)
Review comment:
Yes, this is just a cleanup.
Currently, we have several `BrokerToControllerChannel` for AlterIsrManager,
LifecycleManager, AutoTopicCreateManager and ForwardingManager. My cleanup here
has 2 benifits:
1. Create and manage them all in `BrokerServer` or `KafkaServer`
2. Avoid creating different `ControllerNodeProvider` for each of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
