clolov commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r855727263
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -542,8 +544,16 @@ static Map<String, Object>
appendSerializerToConfig(Map<String, Object> configs,
Map<String, Object> newConfigs = new HashMap<>(configs);
if (keySerializer != null)
newConfigs.put(KEY_SERIALIZER_CLASS_CONFIG,
keySerializer.getClass());
+ else {
+ if (newConfigs.get(KEY_SERIALIZER_CLASS_CONFIG) == null)
+ throw new ConfigException(KEY_SERIALIZER_CLASS_CONFIG + "
configuration for KafkaProducer must be non-null.");
+ }
if (valueSerializer != null)
newConfigs.put(VALUE_SERIALIZER_CLASS_CONFIG,
valueSerializer.getClass());
+ else {
+ if (newConfigs.get(VALUE_SERIALIZER_CLASS_CONFIG) == null)
Review Comment:
Oh, I see. So this check covers the situations a) the key is missing and b)
the key is there and the value is null, while what I suggested would only cover
a). Is there a possibility that you add a comment saying this above the line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
