clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855728894
########## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ########## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand { CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, ConfigDef.Type.STRING, CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL, + in(Utils.enumOptions(classOf[SecurityProtocol]):_*), Review Comment: Ah, I see. The Scala file imports the `in` method https://github.com/apache/kafka/blob/d47c7590ecd377f31b2d20acbcf065f502554252/core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala#L32. Then I am confused - why do we need to unpack the arguments to this method in the Scala files, but not unpack them in the Java ones? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org