karuturi commented on code in PR #11955:
URL: https://github.com/apache/kafka/pull/11955#discussion_r859794942
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -222,6 +223,14 @@ public void stop() {
connectorStatusMetricsGroup.close();
workerConfigTransformer.close();
+ executor.shutdown();
+ try {
+ if
(!executor.awaitTermination(EXECUTOR_SHUTDOWN_TERMINATION_TIMEOUT_MS,
TimeUnit.MILLISECONDS)) {
+ executor.shutdownNow();
+ }
+ } catch (InterruptedException e) {
+ executor.shutdownNow();
+ }
Review Comment:
I missed preserving interrupt status if `InterruptedException` occurs. Also
added the log as suggested in java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
