karuturi commented on code in PR #11955:
URL: https://github.com/apache/kafka/pull/11955#discussion_r860568585
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -222,6 +223,20 @@ public void stop() {
connectorStatusMetricsGroup.close();
workerConfigTransformer.close();
+ executor.shutdown();
+ try {
+ // Wait a while for existing tasks to terminate
+ if
(!executor.awaitTermination(EXECUTOR_SHUTDOWN_TERMINATION_TIMEOUT_MS,
TimeUnit.MILLISECONDS)) {
+ executor.shutdownNow(); //cancel current executing threads
+ // Wait a while for tasks to respond to being cancelled
+ if
(!executor.awaitTermination(EXECUTOR_SHUTDOWN_TERMINATION_TIMEOUT_MS,
TimeUnit.MILLISECONDS))
+ log.error("Pool did not terminate");
Review Comment:
Thanks for the review. corrected the message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
