cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r874258218
########## core/src/main/scala/kafka/raft/RaftManager.scala: ########## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt: Option[String], - val controllerQuorumVotersFuture: CompletableFuture[util.Map[Integer, AddressSpec]] + val controllerQuorumVotersFuture: CompletableFuture[util.Map[Integer, AddressSpec]], + apiVersions: ApiVersions Review Comment: I don't see why we would want to pass a specific `ApiVersions` object in. We're not supplying any information, right? We don't know anything about the versions of the nodes until we start contacting them. So, can we just have an accessor method in `RaftManager` that returns the `ApiVersions` of the `RaftManager`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
