Moovlin commented on PR #12167: URL: https://github.com/apache/kafka/pull/12167#issuecomment-1129000522
@showuon happy to try and help. For my sake since this is the first code contribution I've made, could you help me out by answering some questions? 1. When you say add some test for wrong & good configs, do you mean to remove the particular unit tests and then add it to the `TopicCommandTest.scala` instead? Or are you suggesting that there should be a couple more tests added to cover the usage a bit more completely? 2. In terms of integration testing, that was what I understood this Jira to be originally but upon getting clarification in the Jira I was under the impression that this was only related to the CLI portion of the command and not the functionality. [Link to the comment](https://issues.apache.org/jira/browse/KAFKA-13716?focusedCommentId=17528047&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17528047). So I don't think there is a need for integration testing but I'm happy to be wrong here. Greatly appreciate the feedback and for helping me work through (what I hope is) my first code contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
