Moovlin commented on PR #12167: URL: https://github.com/apache/kafka/pull/12167#issuecomment-1131755255
Thanks for the quick responses. To your first answer, I'm happy to do that and will take a look at the TopciCommandTest for guidance. To your second answer. Integration tests for this should probably be in a different Jira since the methods in the MockAdminClient are effectively not implemented (if you try to do anything other than delete from the first offset, it throws an UnsupportedOperationException). So I'd like to keep the scope of this PR to unit tests. If you think that makes sense, I'll go ahead and open up an issue for it to make sure we track that outstanding item. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
