cadonna commented on code in PR #12169:
URL: https://github.com/apache/kafka/pull/12169#discussion_r879124836
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -452,7 +452,9 @@ public class StreamsConfig extends AbstractConfig {
/** {@code commit.interval.ms} */
@SuppressWarnings("WeakerAccess")
public static final String COMMIT_INTERVAL_MS_CONFIG =
"commit.interval.ms";
- private static final String COMMIT_INTERVAL_MS_DOC = "The frequency in
milliseconds with which to save the position of the processor." +
+ private static final String COMMIT_INTERVAL_MS_DOC = "The frequency in
milliseconds with which to commit processing progress." +
+ " For at-least-once processing, committing means to save the position
(ie, offsets) of the processor." +
+ " For exactly-once processing, it means to commit the transaction
which includes to save the position." +
Review Comment:
When I read the updated doc, the first question that comes to my mind is,
what "commit the transaction" actually means. I would not like to leave a user
with that question in mind. You could add something like
```suggestion
" For exactly-once processing, it means to commit the transaction
which includes to save the position and to make the committed data in the
output topic visible to consumers with isolation level read_committed." +
```
There are more to transactions that just that, but I think those are the
main points.
Mine is just a suggestion, if you think it is not needed, I am fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
