niket-goel commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r882205666
########## clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java: ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.admin; + +import java.util.List; +import java.util.Objects; +import java.util.OptionalLong; + +/** + * This is used to describe per-partition state in the DescribeQuorumResponse. + */ +public class QuorumInfo { + private final String topic; + private final Integer leaderId; + private final List<ReplicaState> voters; + private final List<ReplicaState> observers; + + public QuorumInfo(String topic, Integer leaderId, List<ReplicaState> voters, List<ReplicaState> observers) { + this.topic = topic; + this.leaderId = leaderId; + this.voters = voters; + this.observers = observers; + } + + public String topic() { + return topic; + } + + public Integer leaderId() { + return leaderId; + } + + public List<ReplicaState> voters() { + return voters; + } + + public List<ReplicaState> observers() { + return observers; + } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + QuorumInfo that = (QuorumInfo) o; + return topic.equals(that.topic) + && leaderId.equals(that.leaderId) + && voters.equals(that.voters) + && observers.equals(that.observers); + } + + @Override + public int hashCode() { + return Objects.hash(topic, leaderId, voters, observers); + } + + @Override + public String toString() { + return "QuorumInfo{" + + "topic='" + topic + '\'' + + ", leaderId=" + leaderId + + ", voters=" + voters.toString() + + ", observers=" + observers.toString() + + '}'; + } + + public static class ReplicaState { + private final int replicaId; + private final long logEndOffset; + private final OptionalLong lastFetchTimeMs; + private final OptionalLong lastCaughtUpTimeMs; + + public ReplicaState() { Review Comment: I need the constructor access in `DescribeQuorumResponse.java`. I can sort of work around that by returning the fields raw or encapsulated in a different object, but i thought this was simpler. If we want to prioritize hiding the constructor more, I can change it so that the `getVoterInfo` and `getObserverInfo` return raw fields. Do you have any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
