dengziming commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1138359588
@niket-goel Thanks for the reply, I left 2 minor comments. I still find the class name is `DescribeQuorumIntegrationTest` but the file name is `DescribeQuorumTest.scala`, you should make them the same, I run your newly added tests locally but some of them failed, maybe there are still some bugs to be fixed. For the last problem, I mean we can also get quorum directly from the controller, I can give you an example: For a single node KRaft cluster, we can get quorum info from BrokerServer: ``` properties.put("bootstrap.servers", "localhost:9092"); // connect to BrokerServer 9092 AdminClient client = AdminClient.create(Properties) client.describeMetadataQuorum() ``` We can also connect to ControllerServer: ``` properties.put("bootstrap.servers", "localhost:9093"); // connect to ControllerServer 9093 AdminClient client = AdminClient.create(Properties) client.describeMetadataQuorum() ``` We can leave this problem to a separate PR since it's unrelated here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org