cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/save SaveService.java SaveServiceConstants.java

[sebb]

sebb        2003/10/19 15:28:55

  Modified:    src/core/org/apache/jmeter/save SaveService.java
                        SaveServiceConstants.java
  Log:
  final log; Boolean usage
  
  Revision  Changes    Path
  1.30      +6 -4      jakarta-jmeter/src/core/org/apache/jmeter/save/SaveService.java
  
  Index: SaveService.java
  ===================================================================
  RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/save/SaveService.java,v
  retrieving revision 1.29
  retrieving revision 1.30
  diff -u -r1.29 -r1.30
  --- SaveService.java  5 Oct 2003 01:05:31 -0000       1.29
  +++ SaveService.java  19 Oct 2003 22:28:55 -0000      1.30
  @@ -106,7 +106,9 @@
    */
   public final class SaveService implements SaveServiceConstants
   {
  -    transient private static Logger log = LoggingManager.getLoggerForClass();
  +    transient private static final Logger log = LoggingManager.getLoggerForClass();
  +
  +//TODO: make most/all of these fields private?
   
       protected static final int SAVE_NO_ASSERTIONS = 0;
       protected static final int SAVE_FIRST_ASSERTION = SAVE_NO_ASSERTIONS + 1;
  @@ -378,7 +380,7 @@
              if (saveSuccessful)
              {
                  text = splitter.nextToken();
  -               result.setSuccessful(new Boolean(text).booleanValue());
  +               result.setSuccessful(Boolean.valueOf(text).booleanValue());
              }
           
              if (saveAssertionResultsFailureMessage)
  @@ -659,7 +661,7 @@
           {
               config.setAttribute(
                   SUCCESSFUL,
  -                new Boolean(result.isSuccessful()).toString());
  +                Boolean.valueOf(result.isSuccessful()).toString());
           }
   
           SampleResult[] subResults = result.getSubResults();
  
  
  
  1.6       +1 -2      
jakarta-jmeter/src/core/org/apache/jmeter/save/SaveServiceConstants.java
  
  Index: SaveServiceConstants.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/save/SaveServiceConstants.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- SaveServiceConstants.java 26 Mar 2003 20:51:20 -0000      1.5
  +++ SaveServiceConstants.java 19 Oct 2003 22:28:55 -0000      1.6
  @@ -64,7 +64,6 @@
    *  
    *
    [EMAIL PROTECTED]     <a href="mailto:kcassell&#X0040;apache.org";>Keith Cassell</a>
  - [EMAIL PROTECTED]    $Date$
    [EMAIL PROTECTED]    $Revision$ $Date$
    ***********************************************************/
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]