sebb 2003/10/19 15:30:05
Modified: src/core/org/apache/jmeter/testelement WorkBench.java
TestPlan.java AbstractTestElement.java
src/core/org/apache/jmeter/testelement/property
BooleanProperty.java AbstractProperty.java
Log:
final log; Boolean usage; Javadoc tag usage
Revision Changes Path
1.6 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/testelement/WorkBench.java
Index: WorkBench.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testelement/WorkBench.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- WorkBench.java 5 Oct 2003 01:05:31 -0000 1.5
+++ WorkBench.java 19 Oct 2003 22:30:05 -0000 1.6
@@ -4,8 +4,8 @@
/**
* @author Michael Stover
- * @created March 13, 2001
- * @version $Revision$
+ * Created March 13, 2001
+ * @version $Revision$ Last updated: $Date$
*/
public class WorkBench extends AbstractTestElement implements Serializable
{
1.9 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/testelement/TestPlan.java
Index: TestPlan.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testelement/TestPlan.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- TestPlan.java 5 Oct 2003 01:05:31 -0000 1.8
+++ TestPlan.java 19 Oct 2003 22:30:05 -0000 1.9
@@ -17,8 +17,8 @@
/**
* @author Michael Stover
- * @created March 13, 2001
- * @version $Revision$
+ * Created March 13, 2001
+ * @version $Revision$ Last updated: $Date$
*/
public class TestPlan extends AbstractTestElement implements Serializable
{
1.26 +3 -3
jakarta-jmeter/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
Index: AbstractTestElement.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testelement/AbstractTestElement.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- AbstractTestElement.java 29 Sep 2003 14:56:01 -0000 1.25
+++ AbstractTestElement.java 19 Oct 2003 22:30:05 -0000 1.26
@@ -82,7 +82,7 @@
*/
public abstract class AbstractTestElement implements TestElement, Serializable
{
- protected static Logger log = LoggingManager.getLoggerForClass();
+ protected static final Logger log = LoggingManager.getLoggerForClass();
private Map propMap = Collections.synchronizedMap(new HashMap());
private Set temporaryProperties;
@@ -118,7 +118,7 @@
propMap.remove(key);
}
- public boolean equals(Object o)
+ public boolean equals(Object o) //TODO: probably ought to use hashCode() from
Map as well
{
if (o instanceof AbstractTestElement)
{
1.7 +3 -3
jakarta-jmeter/src/core/org/apache/jmeter/testelement/property/BooleanProperty.java
Index: BooleanProperty.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testelement/property/BooleanProperty.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- BooleanProperty.java 29 Sep 2003 14:56:01 -0000 1.6
+++ BooleanProperty.java 19 Oct 2003 22:30:05 -0000 1.7
@@ -7,7 +7,7 @@
*/
public class BooleanProperty extends AbstractProperty
{
- boolean value;
+ boolean value; //TODO: should these be private?
boolean savedValue;
public BooleanProperty(String name,boolean v)
@@ -46,7 +46,7 @@
*/
public Object getObjectValue()
{
- return new Boolean(value);
+ return Boolean.valueOf(value);
}
/**
1.14 +3 -3
jakarta-jmeter/src/core/org/apache/jmeter/testelement/property/AbstractProperty.java
Index: AbstractProperty.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testelement/property/AbstractProperty.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- AbstractProperty.java 2 Oct 2003 13:36:44 -0000 1.13
+++ AbstractProperty.java 19 Oct 2003 22:30:05 -0000 1.14
@@ -67,7 +67,7 @@
*/
public abstract class AbstractProperty implements JMeterProperty
{
- protected static Logger log = LoggingManager.getLoggerForClass();
+ protected static final Logger log = LoggingManager.getLoggerForClass();
private String name;
private boolean runningVersion = false;
@@ -250,7 +250,7 @@
return Boolean.valueOf(val).booleanValue();
}
- public boolean equals(Object o)
+ public boolean equals(Object o) //TODO probably ought to provide hashCode() as
well
{
return compareTo(o) == 0;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
