Sebastian > > As far as I can make out, the code adds: > > + POP3S and IMAPS > > + Check for failure - i.e require that the connect fails > > + StartTLS support > > + Trusting All certificates > > + various options for trust stores Correct! > > The MailReader Sampler has already been enhanced in JMeter 2.3.2 to > > handle POP3S and IMAPS. I saw these changes, obviously somebody was faster than we were ;-) > > I don't think it makes sense to add the check for failure code - that > > can be done with an Assertion. The check for failure has been added to be able to catch any kind of exceptions to be thrown within the sampler (e.g. within the SSL session, in case no plaintext connection is supported, ...). AFAICR these cases cannot be addressed by an assertion, am I wrong? > > StartTLS looks as though it can be added simply by updating the > > properties list, so is not a problem. Agree. Is this already planned for future releases? > > Trusting all certificates looks OK, as again it just means setting > > some local properties. There's already some JMeter code for > > certificate trust which might be re-usable. If not, then the code you > > supplied can be used once the Copyright notices have been dealt with: OK, copyright notice will be added!
Again (see other thread), I have to admit that the "Install TrustStore" functionality uses the same (sun copyright protected) class as SMTPSampler - if sun licensed files cannot be used within JMeter, this class would have to be re-written. > > The trust store options seem to require setting System properties - > > this is not going to work unless all samplers have the same settings, > > so I don't think the options should be added as they stand. See other thread. Again, can you agree with the following TODO list? - add copyright headers to all files Michael --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
