>> AtomSetCollection is what it will be. > > Done. Great!
> Since you said you'd work on the ModelAdapter, I did not do this one. > I also didn't get around to adding this method to the > SmarterModelAdapter, but will do so soon (in the mean time the default > implementation in the ModelAdapter should work fine). OK > We'd actually > have to come up with a way in which each reader can come up with a > 'good' AtomSetName for each AtomSet. I guess the energy or vibrational > frequency would be good starts for that. Yes Q: Do these atomSets have both a vibrational frequency and an energy? >> And I think you are right that we should change from ModelReader to >> AtomSetCollectionReader. > > Done. Which means I had to remove ModelReader.java and add > AtomSetCollectionReader.java. Correct. > I noticed that there are still quite a few variables and classes that > still have the name Model in them. I did not touch those... OK ... we should try to get those cleaned up tomorrow. >> But we have to change all the references to the Model class to >> AtomSetCollection. > > Done. Good. > I don't like abbreviations for variable names either, so I took the > liberty to call the instances of AtomSetCollection atomSetCollection. I > hope you don't mind. Perfect ... no problem at all. > Oops, I accidentally deleted the old file before I added the new one. > But it caught it soon enough that the repository was without it for > only a few minutes. I hope I didn't mess anybody up... >From the cvs command line you delete files and add files ... but in fact they are only 'tagged' for deletion/addition. It doesn't actually happen until you 'check in' The idea is that you can rearrange things and get everything worked out, then *commit* in an atomic transaction ... like a real database :-) Otherwise, it would be unacceptable for group project development. Rene, you did a *great* job. :-) Miguel ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Jmol-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jmol-developers
