Hi Miguel, it seems a good idea to do this, I will try to work on the Smiles pattern matching code this evening after office to take into account this remark and the others you already gave.
----Message d'origine---- >De: "Miguel" <[EMAIL PROTECTED]> >A: [email protected] >Sujet: [Jmol-developers] Interning strings >Date: Tue, 22 Mar 2005 20:05:05 -0500 (EST) > >Nico, > >The Smiles pattern matching code uses String.equals(String) to compare >element symbols for equality (or to compare against the "*" wildcard) > >The smiles code is being used for pattern matching, so efficiency may be >important. snip >More importantly, in PatternMatcher.searchMatch we can > > String patternSymbol = patternAtom.getSymbol() > if (patternSymbol != "*" && patternSymbol != atom.getElementSymbol()) ------------------------------------------------------- This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at http://ads.osdn.com/?ad_idh82&alloc_id148&op=click _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
