How do I get a valid patch out that that? Jonathan Gutow wrote:
>Bob, > Looks good. I have some changes that make the results even easier >to use in a GUI web editor and that make the pages fail gracefully if >javascript isn't working (it defaults to pictures). So far I've >finished those changes (mostly to the templates) for the popin view. >I am still working on the script button view. I'll send you the >changes as soon as I can figure out where my "create patch" menu item >has gone in Eclipse. It doesn't seem to be showing up in the menus >for the Synchronize view. Did I get confused? > >Jonathan >On Aug 15, 2007, at 10:09 AM, Bob Hanson wrote: > > > >>OK, Jonathan, I've checked in one more small set of modifications. >>This >>should appear as part of Jmol 11.3.10. Yes, I think we are onto >>something here. >> >> I've set it up so that generally the Molecules and Orbitals tabs >>aren't >>there, but if you use from the console or a startup script >> >> webMakerAllTabs = true >> >>prior to opening the web panel, then they do appear. >> >>In addition, if you use: >> >> webMakerCreateJS = true >> >>then Jmol will produce the sort of JavaScript code I was interested in >>having. >> >>Here are some of the major modifications that I performed over the >>last >>couple of days: >> >>--The classes PopInJmol and ScriptButtons (was "Resizable") now >>extend a >>more general class, WebPanel. This reduced redundancy in the code and >>improved consistency. >> >>I really think where this is headed is that we only need one class, >>and >>then simply provide two different buttons. >> >>--Just about all HTML is in the form of templates stored as resources. >> >>This should make development life far easier. >> >>--I rearranged the gizmos on these two pages to give a more >>consistent feel. >> >>Again, probably headed for one panel. >> >>--The two lists are linked, so that if you add, delete, or rearrange >>items on one, the other follows. >> >>I didn't see any particular reason to have to enter the data twice. >> >>--Dragging is fixed. >> >>There was a problem with dragging in that the listener returns the >>Java >>reference code to an object, not the object itself, and there were >>problems with moving items around as well. >> >>--Naming is fixed. >> >>There was a problem with naming -- you could have illegal file names, >>and you could create two items with the same name. >> >>--I added a "Show Selected" button. >> >>Next would be, perhaps, a "Replace Selected" button.. >> >>--I refactored the code to have thisSortOfCaps for variables and >>ThisSortOfStuff for classes. >> >>--I reformated the code to Jmol standard format. >> >> >>Bugs remaining: >> >>- I haven't checked to see that build.xml is pulling in all the >>necessary files. Might need some modification there.... or not. >>- I don't have the JPanel sizing right. >> >>Ideas: >> >>Actually, I'm thinking that this is much bigger than simply a web-page >>maker. I really like that JmolInstance class, and in general this >>could >>be tied to the "save state" command to provide a handy reference to >>saved states. The application actually saves ALL the states when >>commands are given in the console. So, in principle, all those could >>show up on this page as well. >> >>Mostly I'm not interested in developing the application much, but this >>is really intriguing, because "script management" is the sort of thing >>that power users often need to do. I could imagine being able to save >>and restore "script sets" from disk -- perhaps a simple XML varient >>of a >>standard script file, for example, or just comments that are >>meaningful >>so that one file can be loaded into this thing and all the independent >>state scripts will show up. >> >>Or, we could go backward -- load a diretory's worth of script files >>and >>manipulate them. >> >>That is, it could be just as useful for import as for export in the >>area >>of scripts. >> >>I can see Frieda salivating right now -- a built-in script management >>tool. Very interesting... >> >>This is all the time I have for it now. Do you want to develop it from >>here? If you find anything that needs changing, go ahead and fix that >>and send me the patch or do the modification yourself on the trunk if >>you can and just let us know on this list what it was all about. >> >> >> >>Bob >> >> >>Jonathan Gutow wrote: >> >> >> >>>On Aug 14, 2007, at 7:00 PM, Bob Hanson wrote: >>> >>> >>> >>> >>> >>>>John, I think you will like what I just checked in. The >>>>JavaScript is >>>>still there as an unimplemented option, but instead we have two new >>>>templates: >>>> >>>>pop_in_jmol_template2.html >>>>script_button_template2.html >>>> >>>>These are the "per-applet" templates, and I think they will be quite >>>>easily adaptable. >>>> >>>> >>>> >>>> >>>I'll take a look. I've also worked out something based on the code >>>you had checked in this morning. I think we're homing in on >>>something very good. >>> >>> >>> >>> >>>>So I think these two pages are pretty much done. >>>> >>>>I'd like to talk about the other two pages -- "Orbitals" and >>>>"Molecules". Are they useful? It seems to me perhaps these are a bit >>>>anachranistic. For example, why would I load orbitals from different >>>>files anymore? So I'm tempted to comment those out for now.... >>>> >>>> >>>> >>>> >>>I think that commenting them out for the time being is a good idea. >>>There are cases where you might want to load your own surface files >>>and I can imagine wanting to have the ability to load different >>>molecules in from a menu. However, for the novice user I think the >>>resizable case with script buttons is probably more generally >>>useful. Thanks for all your hard work on this. >>> >>>Jonathan >>> >>> >>> >>> >>>>Bob >>>> >>>> >>>> >>>>Jonathan Gutow wrote: >>>> >>>> >>>> >>>> >>>> >>>>>Bob, >>>>> I found the problem. While playing with the page source, I had >>>>>not >>>>>found all the places that the applet path is hard coded into >>>>>the .html. I suggest that a variable called something like >>>>>JmolPath >>>>>be defined early on in the page so that if users do move things >>>>>around all they have to do is change that variable not every >>>>>time the >>>>>path is used. See the source code for the page: >>>>>http://www.uwosh.edu/faculty_staff/gutow/tests/pop-in/test%20pop% >>>>>207/ >>>>>test%20pop%207.html. >>>>> >>>>>Jonathan >>>>> Dr. Jonathan H. Gutow >>>>>Chemistry Department >>>>>[EMAIL PROTECTED] >>>>>UW-Oshkosh Office: >>>>>920-424-1326 >>>>>800 Algoma Boulevard FAX: >>>>>920-424-2042 >>>>>Oshkosh, WI 54901 >>>>> http://www.uwosh.edu/faculty_staff/gutow/ >>>>> >>>>> >>>>> >>>>> >>>>>------------------------------------------------------------------- >>>>>-- >>>>>---- >>>>>This SF.net email is sponsored by: Splunk Inc. >>>>>Still grepping through log files to find problems? Stop. >>>>>Now Search log events and configuration files using AJAX and a >>>>>browser. >>>>>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>>>_______________________________________________ >>>>>Jmol-developers mailing list >>>>>[email protected] >>>>>https://lists.sourceforge.net/lists/listinfo/jmol-developers >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>-- >>>>Robert M. Hanson >>>>Professor of Chemistry >>>>St. Olaf College >>>>Northfield, MN >>>>http://www.stolaf.edu/people/hansonr >>>> >>>> >>>>If nature does not answer first what we want, >>>>it is better to take what answer we get. >>>> >>>>-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 >>>> >>>> >>>> >>>>-------------------------------------------------------------------- >>>>-- >>>>--- >>>>This SF.net email is sponsored by: Splunk Inc. >>>>Still grepping through log files to find problems? Stop. >>>>Now Search log events and configuration files using AJAX and a >>>>browser. >>>>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>>_______________________________________________ >>>>Jmol-developers mailing list >>>>[email protected] >>>>https://lists.sourceforge.net/lists/listinfo/jmol-developers >>>> >>>> >>>> >>>> >>> Dr. Jonathan H. Gutow >>>Chemistry Department [EMAIL PROTECTED] >>>UW-Oshkosh Office: >>>920-424-1326 >>>800 Algoma Boulevard FAX:920-424-2042 >>>Oshkosh, WI 54901 >>> http://www.uwosh.edu/faculty_staff/gutow/ >>> >>> >>> >>> >>>--------------------------------------------------------------------- >>>---- >>>This SF.net email is sponsored by: Splunk Inc. >>>Still grepping through log files to find problems? Stop. >>>Now Search log events and configuration files using AJAX and a >>>browser. >>>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>_______________________________________________ >>>Jmol-developers mailing list >>>[email protected] >>>https://lists.sourceforge.net/lists/listinfo/jmol-developers >>> >>> >>> >>> >>-- >>Robert M. Hanson >>Professor of Chemistry >>St. Olaf College >>Northfield, MN >>http://www.stolaf.edu/people/hansonr >> >> >>If nature does not answer first what we want, >>it is better to take what answer we get. >> >>-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 >> >> >> >>---------------------------------------------------------------------- >>--- >>This SF.net email is sponsored by: Splunk Inc. >>Still grepping through log files to find problems? Stop. >>Now Search log events and configuration files using AJAX and a >>browser. >>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>_______________________________________________ >>Jmol-developers mailing list >>[email protected] >>https://lists.sourceforge.net/lists/listinfo/jmol-developers >> >> > > Dr. Jonathan H. Gutow >Chemistry Department [EMAIL PROTECTED] >UW-Oshkosh Office:920-424-1326 >800 Algoma Boulevard FAX:920-424-2042 >Oshkosh, WI 54901 > http://www.uwosh.edu/faculty_staff/gutow/ > > > > >------------------------------------------------------------------------- >This SF.net email is sponsored by: Splunk Inc. >Still grepping through log files to find problems? Stop. >Now Search log events and configuration files using AJAX and a browser. >Download your FREE copy of Splunk now >> http://get.splunk.com/ >_______________________________________________ >Jmol-developers mailing list >[email protected] >https://lists.sourceforge.net/lists/listinfo/jmol-developers > > -- Robert M. Hanson Professor of Chemistry St. Olaf College Northfield, MN http://www.stolaf.edu/people/hansonr If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
