On 25/04/2013 15:35, Jaroslav Bachorik wrote:
Reviving the review process.

I still need an official openjdk reviewer for this.

Thanks,

-JB-
Just so I understand, the issue is that RemoteServer.getClientHost is returning a String with an IPv6 literal address so you need to enclose it in [] when building the connection id. That seems reasonable to me. A minor comment on the wording of the comment it that it would be clear if there was a comma after "package description".

The test looks okay to me although I had to read it a few times to understand that <proto>:// was being removed from s.

-Alan.


Reply via email to