On Čt 25. duben 2013, 16:49:52 CEST, Alan Bateman wrote: > On 25/04/2013 15:35, Jaroslav Bachorik wrote: >> Reviving the review process. >> >> I still need an official openjdk reviewer for this. >> >> Thanks, >> >> -JB- > Just so I understand, the issue is that RemoteServer.getClientHost is > returning a String with an IPv6 literal address so you need to enclose > it in [] when building the connection id. That seems reasonable to me.
Exactly. > A minor comment on the wording of the comment it that it would be > clear if there was a comma after "package description". Fixed. > > The test looks okay to me although I had to read it a few times to > understand that <proto>:// was being removed from s. I've improved the client address detection - in addition to being more readable it handles properly the <host_id>:<port> form of the IPv4 address. Update webrev @ http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.02 -JB- > > -Alan. > >
