On Mon, 18 Jan 2021 14:10:56 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
> This patch adds some explicit capacity for local refs. New regression test
> fails prior and passes after the patch.
>
> Thoughts?
src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c line
189:
> 187: cmd,
> 188:
> dcmd_info_array[i].num_arguments);
> 189: if (args == NULL) {
Aren't you missing the PopLocalFrame for this return path?
src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c line
214:
> 212: if (obj == NULL) {
> 213: free(dcmd_info_array);
> 214: return NULL;
Again aren't you missing the PopLocalFrame on this return path?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2130
