On Tue, 19 Jan 2021 09:41:27 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge test files into one >> - Adress review feedback from dholmes >> - Merge branch 'master' into JDK-8258836-check-jni-mbeanserver >> - 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo > > test/jdk/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java > line 38: > >> 36: public class DcmdMBeanTestCheckJni { >> 37: >> 38: public static void main(String[] args) throws Exception { > > I thought that handling the whole test in one file is the good style. See for > example ` > test/hotspot/jtreg/gc/stress/TestStressG1Uncommit.java`. OK. Updated the test. ------------- PR: https://git.openjdk.java.net/jdk/pull/2130