On Wed, 9 Jul 2025 23:14:19 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Further doc update
>> - Test udpate (listIterator)
>
> test/jdk/javax/management/generified/ListTypeCheckTest.java line 105:
>
>> 103: ListIterator iter2 = al.listIterator();
>> 104: Object x2 = iter2.next();
>> 105: iter2.add("blah");
>
> Nit: The case #6 is exactly the same as #5.
> Q: Why is it needed?
> I'd suggest to add a comment explaining this case.
> The line 105 should have a comment as at the line 99.
> In general, this test has a lack of comments explaining tests cases (was
> before your fix).
These cases test the ListIterator operations, one case for set, one case for
add. Will update with comment to clarify.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25856#discussion_r2196896204
