On Wed, 9 Jul 2025 23:16:12 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Further doc update
>>  - Test udpate (listIterator)
>
> test/jdk/javax/management/generified/ListTypeCheckTest.java line 110:
> 
>> 108:                         throw new Exception("test wrong");
>> 109:                 }
>> 110:                 throw new Exception("op " + i + " allowed but should 
>> fail on " + al.getClass());
> 
> Nit: This is confusing. If it is allowed then why should it fail.
> At least, it needs to be explained somewhere in the tests.

Thanks Serguei, I hope I've addressed both comments with additional comment 
updates.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25856#discussion_r2196935071

Reply via email to