On Sat, 22 Nov 2025 08:43:07 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename VM methods for endFirstTransition/startFinalTransition > > src/hotspot/share/runtime/mountUnmountDisabler.cpp line 126: > >> 124: || global_start_transition_disable_count() > base_disable_count >> 125: JVMTI_ONLY(|| >> (JvmtiVTSuspender::is_vthread_suspended(java_lang_Thread::thread_id(vthread)) >> || thread->is_suspended())); >> 126: } > > I like this approach with the JVMTIStartTransition and JVMTIEndTransition > helper classes. It is a nice way to decouple the JVMTI part of the protocol. > Introducing the `is_start_transition_disabled()` function was also long > desired. Also, I like the functions `start_transition()` and > `end_transition()` became pretty simple and clean! This is the function that needs a comment why you're testing all these things (and why base_disable_count is one for JVMTI). It's nice as a function that tests all the different values. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28361#discussion_r2561977191
